Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flash Question Answering tutorial #125

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

karthikrangasai
Copy link

@karthikrangasai karthikrangasai commented Dec 15, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

# First, download the data:

# %%
download_data("https://pl-flash-data.s3.amazonaws.com/kaggle_chaii.zip", DATASET_PATH)
Copy link
Member

@Borda Borda Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this to meta-file

Suggested change
download_data("https://pl-flash-data.s3.amazonaws.com/kaggle_chaii.zip", DATASET_PATH)

then we can even skip this cell :]

@Borda
Copy link
Member

Borda commented Jan 7, 2022

@karthikrangasai mind checking the failing tests? :]

@Borda
Copy link
Member

Borda commented Mar 9, 2022

@karthikrangasai could you pls remind me what I have promised here to do to unblock it? 🐰

@karthikrangasai
Copy link
Author

Hello @Borda ,

We had spoken about

  1. the Kaggle API key getting outdated and updating it
  2. enrolling the lightinig kaggle testing account into the competition.

Downloading and sharing the dataset again might have licensing issues.

After this, I don't think we had arrived to a conclusive solution.

@Borda Borda force-pushed the main branch 4 times, most recently from acdd659 to 0bb4a7e Compare April 9, 2022 14:25
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #125 (5157d01) into main (89b94ba) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #125   +/-   ##
===================================
  Coverage    73%    73%           
===================================
  Files         2      2           
  Lines       382    382           
===================================
  Hits        280    280           
  Misses      102    102           

@Borda
Copy link
Member

Borda commented Apr 11, 2022

  1. the Kaggle API key getting outdated and updating it

just re-generated Key and the same issue, also check that the user approved dataset conditions... need to check deeper

@Borda Borda requested a review from rohitgr7 as a code owner August 15, 2022 07:21
@Borda Borda marked this pull request as draft October 3, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Example / Demo / Tutorial PL: Flash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants