Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: pull data #1081

Merged
merged 2 commits into from Jun 9, 2022
Merged

makefile: pull data #1081

merged 2 commits into from Jun 9, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 9, 2022

What does this PR do?

Reaction to #1080 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the test / CI testing or CI label Jun 9, 2022
@Borda Borda marked this pull request as ready for review June 9, 2022 10:05
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1081 (d481793) into master (cb2d553) will decrease coverage by 24%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #1081     +/-   ##
========================================
- Coverage      95%     71%    -24%     
========================================
  Files         181     181             
  Lines        8103    8103             
========================================
- Hits         7672    5762   -1910     
- Misses        431    2341   +1910     

@23pointsNorth
Copy link
Contributor

23pointsNorth commented Jun 9, 2022

I recommend adding

	_data/
	data.zip

to .gitignore as well.

@Borda Borda merged commit 9962764 into master Jun 9, 2022
@Borda Borda deleted the ci/data branch June 9, 2022 11:25
@mergify mergify bot added the ready label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants