summarize total size of model params in bytes

[kartik4949]

What does this PR do?

A simplified version of model size i.e only consider total params for calculating model size.
followup pr of #4810

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified
• Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

[pep8speaks]

Hello @kartik4949! Thanks for updating this PR.

• In the file pytorch_lightning/core/memory.py:

Line 185:73: E261 at least two spaces before inline comment
Line 392:1: E302 expected 2 blank lines, found 1

• In the file tests/core/test_memory.py:

Line 43:53: E261 at least two spaces before inline comment
Line 44:55: E261 at least two spaces before inline comment
Line 44:69: W291 trailing whitespace

Comment last updated at 2021-01-25 01:10:41 UTC

[Borda]

@kartik4949 nice enhancement, mind rebase it on release/1.2-dev?

EDIT: resolved, no action needed any more...

[kartik4949]

@rohitgr7 @Borda @justusschock completed the PR, I think it's ready for merge. suggestions are welcomed :)

[awaelchli]

good work
just needs a bit more polish I think :))

[kartik4949]

@awaelchli @rohitgr7 done with all suggested changes,
merged the two function, will separate them in follow up PR. :)

[awaelchli]

this looks super clean now. great stuff. please ping me with your follow up that you planned, I'd like to have a close look :)

[awaelchli]

just one final request, could you add this to the changelog file? thx

[codecov]

Codecov Report

Merging #5590 (e6dc2ba) into release/1.2-dev (cb58fde) will increase coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5590   +/-   ##
===============================================
  Coverage               92%     92%           
===============================================
  Files                  153     153           
  Lines                10845   10860   +15     
===============================================
+ Hits                 10022   10037   +15     
  Misses                 823     823           

[kartik4949]

@rohitgr7
in changelog,
I should add changes in the unreleased block right?

[rohitgr7]

@rohitgr7
in changelog,
I should add changes in the unreleased block right?

@kartik4949 yes.

[kartik4949]

@rohitgr7
in changelog,
I should add changes in the unreleased block right?

@kartik4949 yes.

done!

[gianscarpe]

LGTM, nice feature!

[tchaton]

Overall, looks good !

[kartik4949]

added test to check model_size with different precision. as suggested by @rohitgr7.