Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog after 1.0.5 #4505

Merged
merged 5 commits into from
Nov 4, 2020
Merged

update changelog after 1.0.5 #4505

merged 5 commits into from
Nov 4, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 3, 2020

What does this PR do?

collect changes after the last release...

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #4505 into master will increase coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4505    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         116     116            
  Lines        9133    8738   -395     
=======================================
- Hits         8212    8105   -107     
+ Misses        921     633   -288     

@Borda Borda changed the title update changelog for 1.0.5 update changelog after 1.0.5 [wip] Nov 4, 2020
@Borda Borda changed the title update changelog after 1.0.5 [wip] update changelog after 1.0.5 Nov 4, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 4, 2020
@Borda Borda merged commit 41c6a13 into master Nov 4, 2020
@Borda Borda deleted the docs/changelog branch November 4, 2020 20:56
@NumesSanguis
Copy link
Contributor

I forgot to include in my pull request a change log update to state that Lightning's to_torchscript(method='trace') now supports trace (as opposed to only 'script'):

Actually support was already introduced in 1.0.2 (not sure?) with this PR merge:

Then with this PR (merged for v1.0.5), some quality fixes and doc string updates have been added:

@Borda
Copy link
Member Author

Borda commented Nov 6, 2020

@NumesSanguis mind send a PR with correction, thx :]

@NumesSanguis
Copy link
Contributor

@Borda Here it is: #4586

@Borda Borda added this to the 1.0.x milestone Nov 10, 2020
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* update changelog

* update

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants