-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
prune ignore #4240
prune ignore #4240
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4240 +/- ##
=======================================
Coverage 90% 90%
=======================================
Files 103 103
Lines 7863 8229 +366
=======================================
+ Hits 7064 7394 +330
- Misses 799 835 +36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can probably also get rid of the logger ignores.
we still have loggers, right? |
Yes, but in testing we have them mocked, so it will work without loggers installed (ci does not install third party loggers anymore). Maybe just try and revert if it fails :) |
ok, lets try... |
What does this PR do?
prune ignore file in base testing as we do not use sklearn metrics anymore...
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭