Add E231 ignore to flake8 checs, conflicts with black

[kumuji]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?
• If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes problem with pep8speaks

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #2108 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2108   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files          75      75           
  Lines        4710    4710           
======================================
  Hits         4067    4067           
  Misses        643     643           

[awaelchli]

I don't understand this change. If one does not use black, this ignores the whitespace rules. Pretty sure this is undesired? With my comment in the other PR I did not mean to say we should ignore the rule simply because I saw a warning. It is likely a bug with black itself.

[Borda]

just thinking what about dictionary {'any-key': 123}

@kumuji mind check is something similar was reported in Black already - that PEP speaks complain about black patterns?

[kumuji]

just thinking what about dictionary {'any-key': 123}

@kumuji mind check is something similar was reported in Black already - that PEP speaks complain about black patterns?

I haven't seen anything like it in black repo, not sure if it is a bug though. It just appears not frequently.

[Borda]

hey, any update here? 🦝

[kumuji]

hey, any update here? raccoon

Seems like this error rarely appears, probably it is not necessary.

[Borda]

just looking around and found psf/black#1289 and psf/black#429
and according to PEP8 black is wrong with this particular formating... https://www.python.org/dev/peps/pep-0008/#pet-peeves
Let's stick with PEP8 and if/when black deals with it, we'll upgrade it... 🐰