Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move results' keys to device (#19813) #19814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Apr 25, 2024

What does this PR do?

Move registered results' keys to the current device. Otherwise internal tensors like cumulated_batch_size will stay on cpu after they are moved there in previous call to teardown().

Removing standalone register_key() method because it's not used outside of this module and we either end up calling .to() twice or might need to require the potential users to call it themselves.

Fixes #19813

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19814.org.readthedocs.build/en/19814/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 25, 2024
@clumsy clumsy force-pushed the fix/move_existing_keys_to_device branch from 99dcf93 to 3db5c52 Compare April 25, 2024 16:26
@clumsy clumsy requested a review from Borda as a code owner April 25, 2024 16:26
@clumsy
Copy link
Contributor Author

clumsy commented Apr 25, 2024

Please check if you have a chance, @awaelchli

@clumsy clumsy force-pushed the fix/move_existing_keys_to_device branch from 3db5c52 to 8085e74 Compare April 25, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing metric keys not moved to device after LearningRateFinder
2 participants