Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#19799 be able to parse save_last of ModelCheckpoint from cli #19808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix/#19799 be able to parse save_last of ModelCheckpoint from cli #19808

wants to merge 1 commit into from
+24 −2

Commits on May 20, 2024

  1. bugfix change annotation of ModelCheckpoint's save_last parameter, so… 

    … jsonargparse can correctly parse inputs such as true, false, etc...

before this change jsonargparse gave errors complaining that strings like 'true' or 'false' were given when the annotation expected Optional[Literal[True, False, 'link']]; this is in contrast to most other bool parameters in the ModelCheckpoint callback's constructor. I also added a test in tests/test_pytorch/checkpointing/test_model_checkpoint.py::test_save_last_cli
    @mariovas3
    mariovas3 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    aca427f View commit details
    Browse the repository at this point in the history