Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for legacy checkpoint created with 2.2.4 #19806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pl-ghost
Copy link
Contributor

@pl-ghost pl-ghost commented Apr 23, 2024

This is automated addition of created checkpoints with the latest lightning release!

@pl-ghost pl-ghost added checkpointing Related to checkpointing pl Generic label for PyTorch Lightning package tests labels Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 2.0, oldest) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.10, 2.1) success
pl-cpu (macOS-11, lightning, 3.10, 2.2) success
pl-cpu (macOS-14, lightning, 3.10, 2.3) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3) success
pl-cpu (windows-2022, lightning, 3.8, 2.0, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.10, 2.2) success
pl-cpu (windows-2022, lightning, 3.10, 2.3) success
pl-cpu (macOS-11, pytorch, 3.8, 2.0) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.0) success
pl-cpu (windows-2022, pytorch, 3.8, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to tests/legacy/back-compatible-versions.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@pl-ghost pl-ghost changed the title Adding test for legacy checkpoint created with 2.2.3 Adding test for legacy checkpoint created with 2.2.4 May 1, 2024
@pl-ghost pl-ghost force-pushed the create-pull-request/patch branch from 23e9e8e to 0eb23a2 Compare May 1, 2024 22:55
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51%. Comparing base (0f12271) to head (0eb23a2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19806      +/-   ##
==========================================
- Coverage      84%      51%     -33%     
==========================================
  Files         424      416       -8     
  Lines       34702    34549     -153     
==========================================
- Hits        29097    17707   -11390     
- Misses       5605    16842   +11237     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing pl Generic label for PyTorch Lightning package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants