New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing FSDP strategy for hpu accelerator #19704
Open
jyothisambolu
wants to merge
7
commits into
Lightning-AI:master
Choose a base branch
from
jyothisambolu:hpu_fsdp_support
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
jyothisambolu
force-pushed
the
hpu_fsdp_support
branch
from
March 27, 2024 02:50
5c02def
to
995aaaa
Compare
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
jyothisambolu
force-pushed
the
hpu_fsdp_support
branch
from
April 2, 2024 06:20
6e8815c
to
f4a22b3
Compare
jyothisambolu
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
April 10, 2024 11:13
Borda
approved these changes
Apr 14, 2024
awaelchli
reviewed
Apr 14, 2024
src/lightning/pytorch/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
jyothisambolu
force-pushed
the
hpu_fsdp_support
branch
from
April 15, 2024 06:52
c854e4e
to
519a480
Compare
jerome-habana
approved these changes
Apr 16, 2024
jerome-habana
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #19753
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19704.org.readthedocs.build/en/19704/