Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WAITING FOR PL CORE MAINTAINER OPINION] Bugfix/17958 multi optimizer step count behaviour #19589

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[WAITING FOR PL CORE MAINTAINER OPINION] Bugfix/17958 multi optimizer step count behaviour #19589

wants to merge 13 commits into from
+221 −56

Commits on Mar 7, 2024

  1. first version

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bd5e175 View commit details
    Browse the repository at this point in the history

  2. add comment to not submit Makefile changes

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cd0340c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:Lightning-AI/pytorch-lightning in… 

    …to multi_opt_step_counter
    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6d8eb59 View commit details
    Browse the repository at this point in the history

  4. add edge condition (wip) + make robust to optimizer list lenght 0

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6bae025 View commit details
    Browse the repository at this point in the history

  5. small comments

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2360ecd View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a8c44ec View commit details
    Browse the repository at this point in the history

  7. small mypy updates

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c286374 View commit details
    Browse the repository at this point in the history

  8. merge remote pre-commit

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b788af4 View commit details
    Browse the repository at this point in the history

  9. switch double to single quotation marks for f-string

    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bb5bc85 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:Lightning-AI/pytorch-lightning in… 

    …to bugfix/17958_multi_optimizer_step_count_behaviour
    @Anner-deJong
    Anner-deJong committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e28e8f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. bug fix: strategy._lightning_optimizers gets overwritten, make strate… 

    …gy stateful so it has access each time when re-assigning. Other bug left: multi dict does not return all should_increment, ending with mismatch of optimizer and should_increment size
    @Anner-deJong
    Anner-deJong committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    1301b78 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:Lightning-AI/pytorch-lightning in… 

    …to bugfix/17958_multi_optimizer_step_count_behaviour
    @Anner-deJong
    Anner-deJong committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    108696f View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6eab1f1 View commit details
    Browse the repository at this point in the history