Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible and easy to use HSDP setting #19504
base: master
Are you sure you want to change the base?
Flexible and easy to use HSDP setting #19504
Changes from 12 commits
312caee
45c1123
0ddc51d
c952536
8fc2404
da3900f
8311be1
d1d719a
3315893
4652b74
4049f60
9c14afe
1f2c3ff
07f7c1b
2ab0423
899e032
4259df2
dbe22f3
2320a4e
b0d4783
9d7dfbe
483f745
ba0b10b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the tuple specification is a feature of Lightning, we should list the device_mesh parameter explicitly in the init args (see the docstring I added). The kwargs are for things that we pass down to FSDP directly.
So I suggest to set
self.device_mesh
and update this attribute here to the actual DeviceMesh 😃There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
device_mesh
is separated fromkwargs
, we will fail the check in_init_sharding_strategy
in theself.__init__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed now. @awaelchli could you take a look again?