New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: adding testing with M1 [1/2: without Fabric] [wip] #19477
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19477 +/- ##
========================================
- Coverage 83% 81% -1%
========================================
Files 424 424
Lines 34930 34930
========================================
- Hits 28819 28394 -425
- Misses 6111 6536 +425 |
@awaelchli shall we skip these MPS tests for not enough memory or make it smaller? |
Those tests don't seem too big. Maybe there's a memory leak making later tests fail. It will need some research |
lets skip Fabric for now and enable for the rest |
What does this PR do?
bump the min mac-12 and adding mac-14 which is M1 machine
ref: https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available
if test are passing, we need:
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @carmocca @Borda