Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/download-artifact & upload-artifact from 3 to 4 #19173

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/_build-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Keep artifact
id: keep-artifact
run: python -c "print('DAYS=' + str(5 if '${{ github.event_name }}'.startswith('pull_request') else 0))" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{ inputs.artifact-name }}
path: dist
Expand All @@ -43,7 +43,7 @@ jobs:
pkg-name: ${{ fromJSON(inputs.pkg-names) }}
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ${{ inputs.artifact-name }}
path: pypi
Expand All @@ -62,7 +62,7 @@ jobs:
mkdir pypi/${{ matrix.pkg-name }}
cp dist/* pypi/${{ matrix.pkg-name }}/

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{ inputs.artifact-name }}
path: pypi
2 changes: 1 addition & 1 deletion .github/workflows/_flagship-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
--capture=no -v --color=yes

- name: Upload recordings
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: flahship-app-${{ matrix.app }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_legacy-checkpoints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
python -c "print('AWS_RUN=' + str('' if '${{inputs.push_to_s3}}' == 'true' else '--dryrun'))" >> $GITHUB_ENV

- name: Upload checkpoints to GitHub Actions artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: checkpoints-${{ github.sha }}
path: ${{ env.legacy_dir }}/checkpoints/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-pkg-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
run: echo "ARTIFACT_DAYS=7" >> $GITHUB_ENV
- name: Upload built docs
if: ${{ matrix.target == 'html' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: docs-${{ matrix.pkg-name }}-${{ github.sha }}
path: docs/build/html/
Expand Down Expand Up @@ -144,7 +144,7 @@ jobs:
# use input if dispatch or git tag
VERSION: ${{ inputs.version || github.ref_name }}
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: docs-${{ matrix.pkg-name }}-${{ github.sha }}
path: docs/build/html/
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
if: github.event_name == 'release'
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
name: ["APP", "FABRIC", "PYTORCH", "LIGHTNING"]
steps:
- uses: actions/checkout@v4 # needed for local action below
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
Expand All @@ -192,7 +192,7 @@ jobs:
name: ["APP", "FABRIC", "PYTORCH", "LIGHTNING"]
steps:
- uses: actions/checkout@v4 # needed for local action below
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: dist-packages-${{ github.sha }}
path: dist
Expand Down