New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fastapi dependency pins #17173

Merged

lantiga merged 18 commits into master from carmocca/app-deps

Apr 12, 2023

Member

carmocca commented Mar 22, 2023 •

edited

What does this PR do?

Fixes #17106
Fixes #17277

cc @Borda @tchaton


          Update fastapi dependency pins

7586bda

carmocca added app dependencies labels

carmocca added this to the 2.0.x milestone

carmocca requested review from lantiga, Borda, tchaton and awaelchli as code owners

March 22, 2023 23:18

carmocca self-assigned this

Contributor

github-actions bot commented Mar 22, 2023 •

edited

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	cancelled	🚫
app-pytest (macOS-11, app, 3.9, latest)	cancelled	🚫
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	cancelled	🚫
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	cancelled	🚫
app-pytest (ubuntu-20.04, app, 3.9, latest)	cancelled	🚫
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to tests/tests_app/components/serve/test_model_inference_api.py, requirements/app/base.txt, requirements/app/test.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/test.txt.

🔴 lightning_app: Azure

Check ID	Status
App.cloud-e2e	failure	❌

These checks are required after the changes to requirements/app/base.txt, requirements/app/test.txt.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/test.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/test.txt.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/app/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

carmocca added the priority: 0 label

awaelchli approved these changes

View reviewed changes

carmocca commented

View reviewed changes

requirements/app/base.txt Outdated Show resolved Hide resolved

requirements/app/base.txt Outdated Show resolved Hide resolved

carmocca added 2 commits

March 23, 2023 02:30


          Apply suggestions from code review

9c54cda


          Update test.txt

e47cb27

carmocca commented

View reviewed changes

requirements/app/test.txt Show resolved Hide resolved

requirements/app/base.txt Outdated Show resolved Hide resolved

carmocca commented

View reviewed changes

requirements/app/base.txt Outdated Show resolved Hide resolved

carmocca added 2 commits

March 23, 2023 03:04


          Update requirements/app/base.txt

59918ff


          Revert "Update requirements/app/base.txt"

6a64bc1

This reverts commit 59918ff.

Member Author

carmocca commented Mar 23, 2023

I think this is blocked by https://github.com/gridai/grid/pull/10087

Borda approved these changes

View reviewed changes

Borda enabled auto-merge (squash)

March 24, 2023 12:19


          Merge branch 'master' into carmocca/app-deps

6c3a664

mergify bot added the ready label

Borda added 2 commits

March 27, 2023 09:58


          Merge branch 'master' into carmocca/app-deps

4d3f511


          Merge branch 'master' into carmocca/app-deps

mergify bot added has conflicts and removed ready labels


          Merge branch 'master' into carmocca/app-deps

2feae78

mergify bot removed the has conflicts label

mergify bot added ready and removed ready labels

carmocca added 9 commits

April 11, 2023 16:40


          cloud update

017ea22


          Merge branch 'master' into carmocca/app-deps

7253ec3


          Bad merge

2d263b7


          fastapi 0.69.0 which pins starlette 0.15.0

0d0fe88


          https://github.com/pydantic/pydantic/issues/1985

397c734


          Avoid CVE: tiangolo/fastapi#3213

174d125


          Strict trio

516f6ec


          Merge branch 'master' into carmocca/app-deps

e798418


          Skip windows test

6409cb8

carmocca requested a review from ethanwharris as a code owner

April 11, 2023 17:31

carmocca commented

View reviewed changes

requirements/app/base.txt Show resolved Hide resolved

awaelchli approved these changes

View reviewed changes

carmocca disabled auto-merge

April 12, 2023 15:32

lantiga merged commit 04fb30b into master

82 of 88 checks passed

lantiga deleted the carmocca/app-deps branch

April 12, 2023 15:33

Borda pushed a commit that referenced this pull request


          Update fastapi dependency pins (#17173)

00e0113

* Update fastapi dependency pins

* Apply suggestions from code review

* Update test.txt

* Update requirements/app/base.txt

* Revert "Update requirements/app/base.txt"

This reverts commit 59918ff.

* cloud update

* Bad merge

* fastapi 0.69.0 which pins starlette 0.15.0

* pydantic/pydantic#1985

* Avoid CVE: tiangolo/fastapi#3213

* Strict trio

* Skip windows test

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 04fb30b)

lantiga pushed a commit that referenced this pull request


          Update fastapi dependency pins (#17173)

5fdb3d8

* Update fastapi dependency pins

* Apply suggestions from code review

* Update test.txt

* Update requirements/app/base.txt

* Revert "Update requirements/app/base.txt"

This reverts commit 59918ff.

* cloud update

* Bad merge

* fastapi 0.69.0 which pins starlette 0.15.0

* pydantic/pydantic#1985

* Avoid CVE: tiangolo/fastapi#3213

* Strict trio

* Skip windows test

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 04fb30b)

Borda pushed a commit that referenced this pull request


          Update fastapi dependency pins (#17173)

1d0842d

* Update fastapi dependency pins

* Apply suggestions from code review

* Update test.txt

* Update requirements/app/base.txt

* Revert "Update requirements/app/base.txt"

This reverts commit 59918ff.

* cloud update

* Bad merge

* fastapi 0.69.0 which pins starlette 0.15.0

* pydantic/pydantic#1985

* Avoid CVE: tiangolo/fastapi#3213

* Strict trio

* Skip windows test

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 04fb30b)

Borda pushed a commit that referenced this pull request


          Update fastapi dependency pins (#17173)

e0da39e

* Update fastapi dependency pins

* Apply suggestions from code review

* Update test.txt

* Update requirements/app/base.txt

* Revert "Update requirements/app/base.txt"

This reverts commit 59918ff.

* cloud update

* Bad merge

* fastapi 0.69.0 which pins starlette 0.15.0

* pydantic/pydantic#1985

* Avoid CVE: tiangolo/fastapi#3213

* Strict trio

* Skip windows test

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 04fb30b)

lantiga pushed a commit that referenced this pull request


          Update fastapi dependency pins (#17173)

44fd6be

* Update fastapi dependency pins

* Apply suggestions from code review

* Update test.txt

* Update requirements/app/base.txt

* Revert "Update requirements/app/base.txt"

This reverts commit 59918ff.

* cloud update

* Bad merge

* fastapi 0.69.0 which pins starlette 0.15.0

* pydantic/pydantic#1985

* Avoid CVE: tiangolo/fastapi#3213

* Strict trio

* Skip windows test

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 04fb30b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

awaelchli awaelchli approved these changes

Borda Borda approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

tchaton Awaiting requested review from tchaton tchaton is a code owner

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner