Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to use TensorBoardLogger with fsspec #16320

Merged
merged 5 commits into from Mar 27, 2023
Merged

Document how to use TensorBoardLogger with fsspec #16320

merged 5 commits into from Mar 27, 2023

Conversation

leoleoasd
Copy link
Contributor

What does this PR do?

Document how to use TensorBoardLogger with fsspec.

see #15728 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 10, 2023
@leoleoasd
Copy link
Contributor Author

leoleoasd commented Jan 10, 2023 •
edited

Do all other loggers support fsspec paths? I'm currently only putting TensorBoardLogger in the document

@awaelchli awaelchli added community This PR is from the community docs Documentation related labels Jan 10, 2023
@awaelchli awaelchli added this to the v1.9 milestone Jan 10, 2023
@leoleoasd
Copy link
Contributor Author

Blocked by #16158. Will update later...

@awaelchli
Copy link
Member

Feel free edit the files and push it without local build. If there are errors, we can help resolve them. The build runs here in the CI.

@awaelchli awaelchli added the ready PRs ready to be merged label Jan 17, 2023
@leoleoasd leoleoasd marked this pull request as draft January 18, 2023 03:02
@mergify mergify bot removed the ready PRs ready to be merged label Jan 18, 2023
@leoleoasd
Copy link
Contributor Author

Let's wait until I got some time to add fsspec support for CSVLogger.

@awaelchli
Copy link
Member

@leoleoasd That's ok if you want to wait. From our side, it would also be fine to land this doc update and do the CSV support in a separate PR. As you wish.

@Borda Borda modified the milestones: v1.9, v1.9.x Jan 19, 2023
@awaelchli
Copy link
Member

@leoleoasd Let's merge this PR? Is it ready?

@leoleoasd
Copy link
Contributor Author

I'll update documentation for tensorbosrdlogger and csvlogger today and then it will be ready.

@leoleoasd leoleoasd marked this pull request as ready for review March 24, 2023 05:15
@leoleoasd leoleoasd requested a review from lantiga as a code owner March 24, 2023 05:15
@mergify mergify bot added the ready PRs ready to be merged label Mar 24, 2023
@leoleoasd leoleoasd requested review from awaelchli and justusschock and removed request for tchaton, awaelchli and justusschock March 24, 2023 05:15
@Borda Borda enabled auto-merge (squash) March 24, 2023 12:17
@Borda Borda merged commit 0360a6b into Lightning-AI:master Mar 27, 2023
75 of 77 checks passed
Borda pushed a commit that referenced this pull request Apr 24, 2023
@leoleoasd @Borda
Document how to use TensorBoardLogger with fsspec (#16320)
cac9ffa 
(cherry picked from commit 0360a6b)
Borda pushed a commit that referenced this pull request Apr 24, 2023
@leoleoasd @Borda
Document how to use TensorBoardLogger with fsspec (#16320)
e9490c6 
(cherry picked from commit 0360a6b)
lantiga pushed a commit that referenced this pull request Apr 26, 2023
@leoleoasd @lantiga
Document how to use TensorBoardLogger with fsspec (#16320)
7c1516f 
(cherry picked from commit 0360a6b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

Assignees
No one assigned
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leoleoasd @awaelchli @Borda @justusschock