Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Fix e2e tests #16146

Merged
merged 1 commit into from Dec 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 18 additions & 28 deletions src/lightning_app/testing/testing.py
Expand Up @@ -386,34 +386,24 @@ def run_app_in_cloud(
process = Process(target=_print_logs, kwargs={"app_id": app_id})
process.start()

if not app.spec.is_headless:
while True:
try:
with admin_page.context.expect_page() as page_catcher:
admin_page.locator('[data-cy="open"]').click()
view_page = page_catcher.value
view_page.wait_for_load_state(timeout=0)
break
except (playwright._impl._api_types.Error, playwright._impl._api_types.TimeoutError):
pass
else:
view_page = None

# Wait until the app is running
while True:
sleep(1)

lit_apps = [
app
for app in client.lightningapp_instance_service_list_lightningapp_instances(
project_id=project.project_id
).lightningapps
if app.name == name
]
app = lit_apps[0]

if app.status.phase == V1LightningappInstanceState.RUNNING:
break
# Wait until the app is running
while True:
sleep(1)

lit_apps = [
app
for app in client.lightningapp_instance_service_list_lightningapp_instances(
project_id=project.project_id
).lightningapps
if app.name == name
]
app = lit_apps[0]

if app.status.phase == V1LightningappInstanceState.RUNNING:
break

view_page = context.new_page()
view_page.goto(f"{app.status.url}/view")

# TODO: is re-creating this redundant?
lit_apps = [
Expand Down