Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImportErrors on Multinode if package not present #15963

Merged
merged 4 commits into from Dec 8, 2022
Merged

Fix ImportErrors on Multinode if package not present #15963

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18961e0
fix importerrors
justusschock Dec 8, 2022
16dc1e5
chlog
Borda Dec 8, 2022
a796528
Merge branch 'master' into multinode_importerror
justusschock Dec 8, 2022
6c3ece2
Merge branch 'master' into multinode_importerror
justusschock Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/lightning_app/components/multi_node/lite.py
View file
Open in desktop
Expand Up @@ -37,11 +37,14 @@ def run(
mps_accelerators = []

for pkg_name in ("lightning.lite", "lightning_" + "lite"):
pkg = importlib.import_module(pkg_name)
lites.append(pkg.LightningLite)
strategies.append(pkg.strategies.DDPSpawnShardedStrategy)
strategies.append(pkg.strategies.DDPSpawnStrategy)
mps_accelerators.append(pkg.accelerators.MPSAccelerator)
try:
pkg = importlib.import_module(pkg_name)
lites.append(pkg.LightningLite)
strategies.append(pkg.strategies.DDPSpawnShardedStrategy)
strategies.append(pkg.strategies.DDPSpawnStrategy)
mps_accelerators.append(pkg.accelerators.MPSAccelerator)
except (ImportError, ModuleNotFoundError):
continue

# Used to configure PyTorch progress group
os.environ["MASTER_ADDR"] = main_address
Expand Down
13 changes: 8 additions & 5 deletions src/lightning_app/components/multi_node/trainer.py
View file
Open in desktop
Expand Up @@ -37,11 +37,14 @@ def run(
mps_accelerators = []

for pkg_name in ("lightning.pytorch", "pytorch_" + "lightning"):
pkg = importlib.import_module(pkg_name)
trainers.append(pkg.Trainer)
strategies.append(pkg.strategies.DDPSpawnShardedStrategy)
strategies.append(pkg.strategies.DDPSpawnStrategy)
mps_accelerators.append(pkg.accelerators.MPSAccelerator)
try:
pkg = importlib.import_module(pkg_name)
trainers.append(pkg.Trainer)
strategies.append(pkg.strategies.DDPSpawnShardedStrategy)
strategies.append(pkg.strategies.DDPSpawnStrategy)
mps_accelerators.append(pkg.accelerators.MPSAccelerator)
except (ImportError, ModuleNotFoundError):
continue

# Used to configure PyTorch progress group
os.environ["MASTER_ADDR"] = main_address
Expand Down