Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore num_nodes when running MultiNode components locally #15806

Merged
merged 9 commits into from Nov 24, 2022
Merged

Ignore num_nodes when running MultiNode components locally #15806

merged 9 commits into from Nov 24, 2022

Commits on Nov 24, 2022

  1. warning message when running num_nodes>1 locally

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f55152a View commit details
    Browse the repository at this point in the history

  2. add test

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    97436cd View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    5b61943 View commit details
    Browse the repository at this point in the history

  4. add changelog

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    2089fbc View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/bugfix/ignore-multi-node-locally… 

    …' into bugfix/ignore-multi-node-locally
    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f4a960c View commit details
    Browse the repository at this point in the history

  6. these tests make little sense

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    255a9c3 View commit details
    Browse the repository at this point in the history

  7. update test

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    bc02f12 View commit details
    Browse the repository at this point in the history

  8. import re

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f8eb547 View commit details
    Browse the repository at this point in the history

  9. Update src/lightning_app/components/multi_node/base.py

    @awaelchli
    awaelchli committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    6bae709 View commit details
    Browse the repository at this point in the history