New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lightning Lite examples #15599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
williamFalcon,
Borda and
tchaton
as code owners
November 9, 2022 11:32
for more information, see https://pre-commit.ci
Borda
approved these changes
Nov 9, 2022
carmocca
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the examples were used in CI, you'll need to update that too
@carmocca Almost resolved. Just a tiny issue with the imports on the Lite GPU CI job. |
carmocca
approved these changes
Nov 10, 2022
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
akihironitta
approved these changes
Nov 10, 2022
Borda
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the examples to use the new CLI (no run method used). See #15506
Lightning Lite is also evolving to be more than just an onboarding tool for Trainer. The focus of the example has shifted away of teaching how to convert to a Lightning module and instead just focuses on showing how to integrate it with your existing PyTorch code.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 馃檭
cc @Borda @carmocca @justusschock @awaelchli