Collective's PREMUL_SUM support with PyTorch 1.13 #15201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15201 +/- ##
=========================================
+ Coverage 62% 84% +21%
=========================================
Files 413 288 -125
Lines 30309 21993 -8316
=========================================
- Hits 18817 18378 -439
+ Misses 11492 3615 -7877 |
Borda
approved these changes
Oct 20, 2022
otaj
approved these changes
Oct 20, 2022
mergify
bot
added
ready
justusschock
approved these changes
Oct 20, 2022
mergify
bot
added
ready
mergify
bot
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-do of #15167
Workaround for pytorch/pytorch#87191
PREMUL_SUM was added in pytorch/pytorch#84243
Things might change after pytorch/pytorch#87303, it's unclear whether the API will change before 1.13 is released.
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca