Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch options for Lightning Lite #14992

Merged
merged 55 commits into from Nov 2, 2022
Merged

Launch options for Lightning Lite #14992

merged 55 commits into from Nov 2, 2022

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Oct 4, 2022

What does this PR do?

Subclassing and overriding LightningLite.run() is no longer required. You can create and use the LightningLite object directly:

import torch.distributed
from lightning_lite import LightningLite

lite = LightningLite()
print("launched", lite.global_rank)
assert torch.distributed.is_initialized()
lite.barrier()
print("end")

To launch the script, a special CLI needs to be used:

python -m lightning_lite.cli example.py --accelerator cuda --devices 2 --precision bf16

The command above will eventually become lightning run ... in the future.

Alternatively, one can launch programmatically:

lite = LightningLite(accelerator="cuda", devices=2)
lite.launch()
...

In Jupyter notebooks (Colab, Kaggle etc.) you would launch like this:

# Notebook cell 1
def training_function(lite):
    lite.setup(model) 
    ...

# Notebook cell 2
lite = LightningLite(accelerator="cuda", devices=2)
lite.launch(training_function)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 5, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement fabric lightning.fabric.Fabric and removed pl Generic label for PyTorch Lightning package labels Oct 5, 2022
@awaelchli awaelchli added this to the pl:future milestone Oct 5, 2022
@awaelchli awaelchli marked this pull request as ready for review October 5, 2022 15:49
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 1, 2022
awaelchli and others added 2 commits November 1, 2022 22:49
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@Borda Borda self-requested a review November 1, 2022 22:23
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Nov 2, 2022
@tchaton
Copy link
Contributor

tchaton commented Nov 2, 2022

@awaelchli Looks great and I really like lightning run lite ... approach.

src/lightning_lite/cli.py Show resolved Hide resolved
src/lightning_lite/cli.py Show resolved Hide resolved
src/lightning_lite/cli.py Outdated Show resolved Hide resolved
src/lightning_lite/cli.py Outdated Show resolved Hide resolved
src/lightning_lite/lite.py Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) November 2, 2022 13:26
@awaelchli awaelchli merged commit 6aa6423 into master Nov 2, 2022
@awaelchli awaelchli deleted the lite/launcher-poc branch November 2, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric feature Is an improvement or enhancement ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants