Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rich 10.15.0 and 10.15.1 #12293

Merged
merged 5 commits into from Mar 18, 2022
Merged

Avoid rich 10.15.0 and 10.15.1 #12293

merged 5 commits into from Mar 18, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Mar 10, 2022

What does this PR do?

Fixes #11034.

Avoids these two versions which seem to cause deadlock as reported in Textualize/rich#1734.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda @SeanNaren @kaushikb11

requirements/extra.txt Outdated Show resolved Hide resolved
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@mergify mergify bot added the ready PRs ready to be merged label Mar 14, 2022
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krshrimali krshrimali enabled auto-merge (squash) March 15, 2022 08:34
@krshrimali krshrimali merged commit 09d1296 into master Mar 18, 2022
@krshrimali krshrimali deleted the bugfix/rich-deadlock branch March 18, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichProgressBar deadlocking during non-distributed training
7 participants