Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create loggers property for Trainer and LightningModule #11683

Merged
merged 63 commits into from Feb 9, 2022
Merged

Create loggers property for Trainer and LightningModule #11683

merged 63 commits into from Feb 9, 2022

Commits on Feb 1, 2022

  1. Implement logger property, replace self.logger

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    2883fb2 View commit details
    Browse the repository at this point in the history

  2. Fix small bugs

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    3ae0a6e View commit details
    Browse the repository at this point in the history

  3. Fixed initalization bug

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    6d917a4 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    30d3a57 View commit details
    Browse the repository at this point in the history

  5. Fix for case where creating a LoggerCollection of size 1

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    62c9335 View commit details
    Browse the repository at this point in the history

  6. Better fix for the LoggerCollection of size 1 issue

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    99a4d98 View commit details
    Browse the repository at this point in the history

  7. Change trainer.loggers from a property to an instance variable

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    01287ba View commit details
    Browse the repository at this point in the history

  8. Revert all instances of trainer.loggers being used

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    41cbab0 View commit details
    Browse the repository at this point in the history

  9. Use logger param to initialize trainer.loggers

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    d78d98f View commit details
    Browse the repository at this point in the history

  10. Remove unneeded newlines

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    7f809ff View commit details
    Browse the repository at this point in the history

  11. Implement unit test for loggers property

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    179f3d4 View commit details
    Browse the repository at this point in the history

  12. make trainer.loggers by default an empty list

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    1ad542a View commit details
    Browse the repository at this point in the history

  13. Update changelog

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    c5df0ad View commit details
    Browse the repository at this point in the history

  14. fix unit test according to suggestions

    @akashkw
    akashkw committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9d564d8 View commit details
    Browse the repository at this point in the history

  15. Update CHANGELOG.md 

    Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
    @akashkw @ananthsub
    akashkw and ananthsub committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9d7c1bf View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Remove unnecessary Trainer params

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    d263659 View commit details
    Browse the repository at this point in the history

  2. Remove tmpdir parameter for unit test 

    Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
    @akashkw @carmocca
    akashkw and carmocca committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    befad11 View commit details
    Browse the repository at this point in the history

  3. Write setters for logger and loggers

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    4773c26 View commit details
    Browse the repository at this point in the history

  4. Unit test for setters

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    8871c36 View commit details
    Browse the repository at this point in the history

  5. Fix bug where logger setter is called twice

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    65ae649 View commit details
    Browse the repository at this point in the history

  6. Fix initialization bug with trainer test

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    df992de View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5e47ef4 View commit details
    Browse the repository at this point in the history

  8. Get rid of extra DummyLogger assignment

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    d55f626 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'refactor/create-loggers-property' of github.com:akashkw… 

    …/pytorch-lightning into refactor/create-loggers-property
    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3debee7 View commit details
    Browse the repository at this point in the history

  10. flake and mypy fixes

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    29778b1 View commit details
    Browse the repository at this point in the history

  11. Flake fix did not commit properly

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    506e5fd View commit details
    Browse the repository at this point in the history

  12. Small changes based on suggestions

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    144169b View commit details
    Browse the repository at this point in the history

  13. Shorten setters and update unit test

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    bdcbcfb View commit details
    Browse the repository at this point in the history

  14. Move unit test to a new file

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    d42ce90 View commit details
    Browse the repository at this point in the history

  15. flake and mypy fixes

    @akashkw
    akashkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    4001efc View commit details
    Browse the repository at this point in the history

  16. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    9401fb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Refactor setter to handle special case of size 1 LoggerCollection

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    e2be787 View commit details
    Browse the repository at this point in the history

  2. Remove DummyLogger changes

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    1e71c40 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into refactor/create-loggers-property

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    4418f10 View commit details
    Browse the repository at this point in the history

  4. Commit suggestion to change None to [] 

    Co-authored-by: Danielle Pintz <38207072+daniellepintz@users.noreply.github.com>
    @akashkw @daniellepintz
    akashkw and daniellepintz committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    c96534b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into refactor/create-loggers-property

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    6a6e2ef View commit details
    Browse the repository at this point in the history

  6. Decouple both setters for readability

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7fef6fd View commit details
    Browse the repository at this point in the history

  7. Fix merge conflicts

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    f2a598f View commit details
    Browse the repository at this point in the history

  8. Fix tiny bug in trainer.loggers setter

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a669a98 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into refactor/create-loggers-property

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b6d6fba View commit details
    Browse the repository at this point in the history

  10. Add loggers property to lightning.py

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    8714857 View commit details
    Browse the repository at this point in the history

  11. update changelog

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a7a47f1 View commit details
    Browse the repository at this point in the history

  12. Add logger property to docs

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    15fa585 View commit details
    Browse the repository at this point in the history

  13. Fix typo

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    3f195be View commit details
    Browse the repository at this point in the history

  14. update trainer.rst

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    c944f9a View commit details
    Browse the repository at this point in the history

  15. correct spacing

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    e3312d5 View commit details
    Browse the repository at this point in the history

  16. remove typing for now

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    88b3c24 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' into refactor/create-loggers-property

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    89f5037 View commit details
    Browse the repository at this point in the history

  18. Fix jit unused issue

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    85256e7 View commit details
    Browse the repository at this point in the history

  19. Fix underlines in docs

    @akashkw
    akashkw committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7ab3683 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Updates based on suggestions

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    c51f336 View commit details
    Browse the repository at this point in the history

  2. More updates to docs based on suggestions

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    ec99acd View commit details
    Browse the repository at this point in the history

  3. Create unit test for lightningmodule loggers property

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    ba09e27 View commit details
    Browse the repository at this point in the history

  4. Replace Mock with Trainer

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    bc6fd72 View commit details
    Browse the repository at this point in the history

  5. Update types

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    f5b492d View commit details
    Browse the repository at this point in the history

  6. Remove list cast

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    8800ec8 View commit details
    Browse the repository at this point in the history

  7. Remove unit test for unsupported behavior

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    5852ee2 View commit details
    Browse the repository at this point in the history

  8. Handle special case for setter

    @akashkw
    akashkw committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    0752fb5 View commit details
    Browse the repository at this point in the history

  9. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    46b5ae1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Update docs/source/common/lightning_module.rst 

    Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
    @akashkw @ananthsub
    akashkw and ananthsub committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    3480c38 View commit details
    Browse the repository at this point in the history

  2. Refactor docs and trainer according to suggestions

    @akashkw
    akashkw committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cd90c34 View commit details
    Browse the repository at this point in the history

  3. Resolve merge conflicts

    @akashkw
    akashkw committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cd43e25 View commit details
    Browse the repository at this point in the history

  4. Update unit tests with new behavior

    @akashkw
    akashkw committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    338ba43 View commit details
    Browse the repository at this point in the history