Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip testing with PyTorch 1.7 and Python 3.9 on Ubuntu #11217

Merged
merged 68 commits into from
Jan 7, 2022
Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 22, 2021

What does this PR do?

Fixes #11184.

Skips testing with PyTorch 1.7 and Python 3.9 on Ubuntu due to a known issue with the setting: #11217 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta
Copy link
Contributor Author

wip

@akihironitta akihironitta changed the title Investigation of seg fault in CI [wip] Investigation of seg fault in CI Dec 22, 2021
@carmocca
Copy link
Contributor

Looks like it's not the coverage as it still segfaulted.

Reading online, this could be useful

https://docs.python.org/3/library/faulthandler.html

python -X faulthandler -m pytest tests ...

@akihironitta akihironitta added bug Something isn't working ci Continuous Integration labels Dec 26, 2021
@carmocca
Copy link
Contributor

carmocca commented Jan 6, 2022

So the problem was reported already but the fix only made it to 1.8, we'll need to exclude this job parametrization

@akihironitta
Copy link
Contributor Author

akihironitta commented Jan 7, 2022

@carmocca Thank you very much for taking your time and investigating this! 🎉

So the problem was reported already but the fix only made it to 1.8, we'll need to exclude this job parametrization

I had a look at the GitHub issue before and had it in my mind, but simply running gdb didn't provide such info (i.e. pybind11::gil_scoped_acquire...). I'm curious, for future debugging, about how you've got to see the above core dump. I'm assuming you've done via ssh to the session, correct? Confirmed so via ssh using tmate.

@akihironitta
Copy link
Contributor Author

Just for the record, this issue seems to have been resolved in #50998 which is included in v1.8.0 as seen in their release note: https://github.com/pytorch/pytorch/releases/tag/v1.8.0

@akihironitta akihironitta changed the title [wip] Investigation of seg fault in CI Skip testing with PyTorch 1.7 and Python 3.9 on Ubuntu Jan 7, 2022
@akihironitta akihironitta added this to the 1.5.x milestone Jan 7, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 7, 2022
@carmocca carmocca merged commit 8e8d4c5 into master Jan 7, 2022
@carmocca carmocca deleted the ci/fix-segfault branch January 7, 2022 13:09
@@ -21,6 +21,9 @@ jobs:
python-version: ["3.7", "3.9"] # minimum, maximum
requires: ["oldest", "latest"]
release: ["stable"]
exclude:
# Skip if torch<1.8 and py3.9 on Linux: https://github.com/pytorch/pytorch/issues/50014
- {os: ubuntu-18.04, python-version: "3.9", requires: "oldest", release: "stable"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I would not run any oldest for py3.9

- {python-version: "3.9", requires: "oldest"}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda Could I ask why you wouldn't? This problem shouldn't apply to other oldest settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use release: "stable" is redundant since we do not have other release values then stable now
and in general, if someone is using almost the latest python I don't think he would assist on the oldest packages...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use release: "stable" is redundant since we do not have other release values then stable now

👍

in general, if someone is using almost the latest python I don't think he would assist on the oldest packages...

I see your point. I've just created an issue #11367 to gain some visibility on this.

justusschock pushed a commit that referenced this pull request Jan 11, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
rohitgr7 pushed a commit that referenced this pull request Jan 11, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Jan 19, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpu (ubuntu-18.04, 3.9, oldest, stable) fails with segmentation fault
5 participants