Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frozen dataclass instance error in apply_to_collection #10927

Merged
merged 13 commits into from Jan 5, 2022
Merged

Fix frozen dataclass instance error in apply_to_collection #10927

Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4b374c4
Fix frozen dataclass instance error in apply_to_collection function
abhi-rf Dec 3, 2021
ee9445a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 10, 2021
8ae6eef
fix: remove unused imports
abhi-rf Dec 10, 2021
4aabc2d
fix: remove unused imports
abhi-rf Dec 10, 2021
fb376bb
fix: remove unused imports
abhi-rf Dec 10, 2021
7ba3eca
fix: remove object.__setattr__ and raise error instead
abhi-rf Dec 10, 2021
7f3b944
fix: remove bare except
abhi-rf Dec 10, 2021
05803f1
Update pytorch_lightning/utilities/apply_func.py
abhi-rf Dec 10, 2021
b79b3e5
Use Misconfig
carmocca Jan 5, 2022
1d8a1bf
Add test
carmocca Jan 5, 2022
cef750e
Reword
carmocca Jan 5, 2022
4405bc9
CHANGELOG
carmocca Jan 5, 2022
3089728
Merge branch 'master' into bugfix/10873_frozen-dataclasses
carmocca Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion pytorch_lightning/utilities/apply_func.py
View file
Open in desktop
Expand Up @@ -144,7 +144,10 @@ def apply_to_collection(
)
if not field_init or (not include_none and v is None): # retain old value
v = getattr(data, field_name)
setattr(result, field_name, v)
try:
setattr(result, field_name, v)
except Exception:
abhi-rf marked this conversation as resolved.
Show resolved Hide resolved
raise dataclasses.FrozenInstanceError("Cannot apply function to Frozen dataclass instance")
return result

# data is neither of dtype, nor a collection
Expand Down