Skip to content

Commit

Permalink
skip True
Browse files Browse the repository at this point in the history
  • Loading branch information
Borda committed Nov 28, 2022
1 parent c0c0e97 commit ccdf442
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions tests/tests_app/core/test_lightning_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def run(self):


# TODO: Find why this test is flaky.
@pytest.mark.skipif(True, reason="flaky test.")
@pytest.mark.skip(reason="flaky test.")
@pytest.mark.parametrize("runtime_cls", [SingleProcessRuntime])
def test_app_state_api_with_flows(runtime_cls, tmpdir):
"""This test validates the AppState can properly broadcast changes from flows."""
Expand Down Expand Up @@ -180,7 +180,7 @@ def maybe_apply_changes(self):


# FIXME: This test doesn't assert anything
@pytest.mark.skipif(True, reason="TODO: Resolve flaky test.")
@pytest.mark.skip(reason="TODO: Resolve flaky test.")
@pytest.mark.parametrize("runtime_cls", [SingleProcessRuntime, MultiProcessRuntime])
def test_app_stage_from_frontend(runtime_cls):
"""This test validates that delta from the `api_delta_queue` manipulating the ['app_state']['stage'] would
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_app/core/test_lightning_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ def run(self):


# TODO (tchaton) Resolve this test.
@pytest.mark.skipif(True, reason="flaky test which never terminates")
@pytest.mark.skip(reason="flaky test which never terminates")
@pytest.mark.parametrize("runtime_cls", [MultiProcessRuntime])
@pytest.mark.parametrize("use_same_args", [False, True])
def test_state_wait_for_all_all_works(tmpdir, runtime_cls, use_same_args):
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_app/structures/test_structures.py
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def run(self):
self.counter += 1


@pytest.mark.skipif(True, reason="tchaton: Resolve this test.")
@pytest.mark.skip(reason="tchaton: Resolve this test.")
@pytest.mark.parametrize("runtime_cls", [MultiProcessRuntime, SingleProcessRuntime])
@pytest.mark.parametrize("run_once_iterable", [False, True])
@pytest.mark.parametrize("cache_calls", [False, True])
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_app/utilities/packaging/test_docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from lightning_app.utilities.redis import check_if_redis_running


@pytest.mark.skipif(True, reason="FIXME (tchaton)")
@pytest.mark.skip(reason="FIXME (tchaton)")
@pytest.mark.skipif(not _is_docker_available(), reason="docker is required for this test.")
@pytest.mark.skipif(not check_if_redis_running(), reason="redis is required for this test.")
@_RunIf(skip_windows=True)
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_lite/test_parity.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def run(rank, model, train_dataloader, num_epochs, precision, accelerator, tmpdi
_atomic_save(model.state_dict(), os.path.join(tmpdir, "model_spawn.pt"))


@pytest.mark.skipif(True, reason="Skipping as it takes 80 seconds.")
@pytest.mark.skip(reason="Skipping as it takes 80 seconds.")
@RunIf(min_cuda_gpus=2)
@pytest.mark.parametrize(
"precision, strategy, devices, accelerator",
Expand Down

0 comments on commit ccdf442

Please sign in to comment.