fix unit test according to suggestions

Lightning-AI · Feb 1, 2022 · 9d564d8 · 9d564d8
1 parent c5df0ad
commit 9d564d8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tests/loggers/test_base.py b/tests/loggers/test_base.py
@@ -176,7 +176,7 @@ def training_step(self, batch, batch_idx):
     assert logger2.finalized_status == "success"
 
 
-def test_loggers_property(tmpdir):
+def test_trainer_loggers_property(tmpdir):
     logger1 = CustomLogger()
     logger2 = CustomLogger()
 
@@ -190,10 +190,10 @@ def test_loggers_property(tmpdir):
 
     assert trainer.loggers == [logger1]
 
-    # trainer.loggers should be None
+    # trainer.loggers should be an empty list
     trainer = Trainer(max_steps=2, log_every_n_steps=1, logger=False, default_root_dir=tmpdir)
 
-    assert trainer.loggers is []
+    assert trainer.loggers == []
 
     # trainer.loggers should be a list of size 1 holding the default logger
     trainer = Trainer(max_steps=2, log_every_n_steps=1, logger=True, default_root_dir=tmpdir)