Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config URLs for pinned version #1182

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Config URLs for pinned version #1182

wants to merge 1 commit into from

Conversation

awaelchli
Copy link
Member

POC
Fixes #1145

The shortcut

--config litgpt://finetune/phi-2/lora.yaml

maps to

https://github.com/Lightning-AI/litgpt/blob/0.2.0/config_hub/finetune/phi-2/lora.yaml

with the appropriate litgpt version substituted

carmocca
carmocca reviewed Mar 24, 2024
View reviewed changes
litgpt/__main__.py
if "--config" not in sys.argv:
return

position = sys.argv.index("--config") + 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that there can be multiple --config arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest pinned commits in config URLs
2 participants
@awaelchli @carmocca