Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Lite launcher into Lightning CLI #15506

Merged
merged 29 commits into from Nov 10, 2022
Merged

Integrate Lite launcher into Lightning CLI #15506

merged 29 commits into from Nov 10, 2022

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Nov 3, 2022

What does this PR do?

This PR changes the Lite CLI from argparse to click to be integrated into the main lightning CLI. Originally we though we can wrap the argparse CLI into click, but this doesn't work well. The simple solution seems to be the best. The click package has no dependencies.

lightning run --help
Usage: lightning run [OPTIONS] COMMAND [ARGS]...

  Run a Lightning application locally or on the cloud.

Options:
  --help  Show this message and exit.

Commands:
  app   Run an app from a file.
  lite  Run a Lightning Lite script.

The lite subcommand is only available if lightning-lite is installed. The name here is not final, it remains to be decided.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added the app Generic label for Lightning App package label Nov 3, 2022
@awaelchli awaelchli added fabric lightning.fabric.Fabric app:cli labels Nov 4, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 4, 2022
@awaelchli awaelchli self-assigned this Nov 4, 2022
@awaelchli awaelchli marked this pull request as ready for review November 8, 2022 09:33
@mergify mergify bot added the has conflicts label Nov 8, 2022
@Borda Borda requested a review from hhsecond as a code owner November 8, 2022 17:17
@mergify mergify bot removed the has conflicts label Nov 8, 2022
@Borda Borda enabled auto-merge (squash) November 8, 2022 17:21
@awaelchli awaelchli mentioned this pull request Nov 9, 2022
11 tasks
requirements/app/base.txt Outdated Show resolved Hide resolved
requirements/lite/base.txt Outdated Show resolved Hide resolved
src/lightning_lite/cli.py Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Should we support lightning run model --cloud

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Nov 9, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 10, 2022
src/lightning_lite/cli.py Show resolved Hide resolved
src/lightning_lite/cli.py Outdated Show resolved Hide resolved
@Borda Borda merged commit 657c674 into master Nov 10, 2022
@Borda Borda deleted the lite/cli-integration2 branch November 10, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:cli app Generic label for Lightning App package fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants