Adding custom color palette #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| @@ -12,7 +12,7 @@ const Dialog = ({ PaperProps, ...props }: DialogProps) => { | |||
| ...PaperProps, | |||
| style: { | |||
| borderRadius: "8px", | |||
| background: theme.palette.background.default, | |||
| background: theme.palette.background.secondary, | |||
There was a problem hiding this comment.
Can you please PR this separately and show screenshots displaying the impact in the product to keep this PR focused?
yurijmikhalevich
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of cleaning up dark mode requires adding a handful of color styles to the palette. In order for this not to be disruptive, and given MUI's many limitations, I've created a
custompalette that standardizes background, text, and border styles.An advantage of this approach is that the new colors won't appear unless explicitly called. It will drastically cut down on the use of
isDarkin ternary operations used through thegridmonorepo.What follows is a visual overview of the changes.
Background
Text
Borders
Additional screens that depict the difference appear in Figma.
Limitations
Declaring custom styles in MUI is cumbersome and requires extensive reworking of the type declarations in the design system—an undertaking worth considering, but well beyond the scope of this project.
Test Plan
This PR is a cleaned up version of a few other draft PRs whose hash we copied into the
package.jsonin thegridrepo to test.