Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added tensor long #402

Merged
merged 1 commit into from May 13, 2024
Merged

feat: added tensor long #402

merged 1 commit into from May 13, 2024

Conversation

k223kim
Copy link
Contributor

@k223kim k223kim commented May 13, 2024 •
edited

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #268.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

⚡️

@k223kim k223kim marked this pull request as ready for review May 13, 2024 15:06
mruberry
mruberry approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @k223kim!

@mruberry mruberry merged commit 6a94fc1 into Lightning-AI:main May 13, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta robieta is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TensorBase.long
2 participants
@k223kim @mruberry