Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dropout from LitGPTSDPABenchmark #378

Merged
merged 5 commits into from May 13, 2024
Merged

Remove dropout from LitGPTSDPABenchmark #378

merged 5 commits into from May 13, 2024

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented May 7, 2024

What does this PR do?

Fixes #317

@carmocca carmocca self-assigned this May 7, 2024
t-vi
t-vi approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @carmocca

@t-vi t-vi merged commit 83ccc18 into main May 13, 2024
37 checks passed
@t-vi t-vi deleted the carmocca/fix-litgpt-sdpa-benchmark branch May 13, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta robieta is a code owner

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LitGPTSDPABenchmark runs incorrect configs
2 participants
@carmocca @t-vi