New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add adaptive_avg_pool2d #363
Conversation
for more information, see https://pre-commit.ci
Hi @nikitaved , I fixed the test case, could you help to take a look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, now I am back! LGTM! Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @kiya00! I made some small comments for your review.
@IvanYashchuk would you like to take a look at this, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the meta functions from prims.py
to the torch file and remove the prims.*
functions. They don't add any value since it's a rather direct path from thunder.torch.adaptive_avg_pool2d
-> thunder.prims.adaptive_avg_pool2d
.
Once it's done let's merge it.
Thank you @kiya00 @nikitaved @IvanYashchuk @mruberry |
Before submitting
What does this PR do?
Fixes #346 .