Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_nested=False #319

Merged
merged 13 commits into from May 15, 2024
Merged

Conversation

Fuzzkatt
Copy link
Collaborator

Attempt to fix #287

@Fuzzkatt
Copy link
Collaborator Author

cc @mruberry: Following your suggestion #93 (comment) that you linked in the original issue, I found out how to do the first half of the suggestion setting is_nested to always False. Could you review and add some suggestions on how to add the second half (ensuring that programs using nestedtensors always fail)?

@mruberry
Copy link
Collaborator

mruberry commented May 1, 2024

This is great, @Fuzzkatt, and I think we can stop this PR here. It does exactly what it should. Failing when provided with a nested tensor can be a separate issue (and should maybe be checked in the prologue, fyi @t-vi).

Would you add a test for this property, following the pattern here:

tensor_properties: list[OpInfo] = []

and then let's merge this!

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Let's see if this unblocks operators that were testing for is_nested.

@Borda and @t-vi to merge

@mruberry mruberry enabled auto-merge (squash) May 2, 2024 15:14
@mruberry
Copy link
Collaborator

mruberry commented May 6, 2024

@Fuzzkatt Looks like this picked up some conflicts that need to be resolved before it's merged

@mruberry
Copy link
Collaborator

mruberry commented May 8, 2024

@t-vi this needs to be merged manually because of flaky ci

@t-vi
Copy link
Collaborator

t-vi commented May 10, 2024

@Fuzzkatt @mruberry Thank you. Could you please resolve the merge conflicts? I'll check for CI issues and override as eneded.

@mruberry mruberry merged commit 4663b87 into Lightning-AI:main May 15, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch.nn.MultiheadAttention with thunder.jit error
4 participants