Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_phantom_grad: support ops which return non-differentiable outputs #293

Merged
merged 5 commits into from May 23, 2024
Merged

test_phantom_grad: support ops which return non-differentiable outputs #293

merged 5 commits into from May 23, 2024

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Apr 29, 2024 •
edited

Fixes: #119 (and also add xfail for getitem grad tests on Windows)

@kshitij12345 kshitij12345 marked this pull request as ready for review April 29, 2024 14:44
@kshitij12345
Copy link
Collaborator Author

Windows failure looks related to : #296

nikitaved
nikitaved reviewed Apr 30, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
@kshitij12345 kshitij12345 changed the title test_phantom_grad: support ops which return non-differentiable outputs test_phantom_grad: support ops which return non-differentiable outputs (and xfail getitem grad tests on Windows) Apr 30, 2024
@kshitij12345 kshitij12345 changed the title test_phantom_grad: support ops which return non-differentiable outputs (and xfail getitem grad tests on Windows) test_phantom_grad: support ops which return non-differentiable outputs May 13, 2024
@t-vi t-vi enabled auto-merge (squash) May 23, 2024 13:58
t-vi
t-vi approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kshitij12345 @nikitaved

@t-vi t-vi merged commit b7154dc into Lightning-AI:main May 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitaved nikitaved nikitaved left review comments

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta robieta is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test phantom grad fails with ops that return tensors that do not require grad
3 participants
@kshitij12345 @nikitaved @t-vi