Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TensorBase.long #268

Closed
athitten opened this issue Apr 24, 2024 · 2 comments 路 Fixed by #402
Closed

Implement TensorBase.long #268

athitten opened this issue Apr 24, 2024 · 2 comments 路 Fixed by #402
Labels
good first issue Good for newcomers nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented Apr 24, 2024 •
edited by github-actions bot

馃殌 Feature

Implement TensorBase.long

Motivation

NeMo Stable Diffusion

cc @tfogal
@athitten athitten added the enhancement New feature or request label Apr 24, 2024
@athitten athitten mentioned this issue Apr 24, 2024
Open
7 tasks
@tfogal tfogal added nemo Issues needed to support NVIDIA NeMo models. triage review and removed enhancement New feature or request labels Apr 29, 2024
@tfogal
Copy link
Collaborator

tfogal commented May 1, 2024

triage team: AFAICT none of NeMo's use cases for this use the memory_format parameter. maybe we could have a half-implementation of this that errors out when this parameter is used?

@mruberry mruberry added good first issue Good for newcomers and removed triage review labels May 6, 2024
@k223kim k223kim mentioned this issue May 13, 2024
Merged
4 tasks
@k223kim
Copy link
Contributor

k223kim commented May 13, 2024

@tfogal Yeah, as .long will call .to, I think memory_format will be handled accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added tensor long k223kim/lightning-thunder
4 participants
@tfogal @mruberry @athitten @k223kim