Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: source CUDA ver. from nvcc #106

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

ci: source CUDA ver. from nvcc #106

wants to merge 6 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 2, 2023

What does this PR do?

Use nvcc instead of torch to source base CUDA docker images.
See the reason why not to source nvidia-smi: NVIDIA/nvidia-container-toolkit#300
BUT nvcc is missing in runtime docker images...

Before submitting
  • Was this discussed/agreed via a GitHub issue? (no need for typos and docs improvements)
  • Did you create/update your configuration file? (in case you are adding new integration)
  • Did you set runtimes in config for GitHub action integration?
  • Are all integration tests passing?

@Borda Borda added the enhancement New feature or request label Mar 2, 2023
@Borda Borda requested a review from akihironitta as a code owner March 2, 2023 13:14
@Borda Borda enabled auto-merge (squash) March 2, 2023 13:14
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #106 (5e0e540) into main (d30ef2f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   NVIDIA/nvidia-docker#106   +/-   ##
===================================
  Coverage    80%    80%           
===================================
  Files         2      2           
  Lines       252    252           
===================================
  Hits        201    201           
  Misses       51     51           

@Borda Borda marked this pull request as draft March 2, 2023 13:44
auto-merge was automatically disabled March 2, 2023 13:44

Pull request was converted to draft

@Borda Borda changed the title ci: source CUDA ver. from nvidia-smi ci: source CUDA ver. from nvcc Mar 2, 2023
@stale stale bot added the won't fix label May 21, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot May 22, 2023
@stale stale bot removed the won't fix label May 22, 2023
@Borda Borda marked this pull request as ready for review May 22, 2023 12:06
@Borda Borda marked this pull request as draft July 20, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant