Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable silead driver modules in kernel config #8483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stpf99
Copy link

@stpf99 stpf99 commented Jan 5, 2024

enable silead driver modules in kernel config

@chewitt
Copy link
Member

chewitt commented Jan 5, 2024

I pushed changes to your repo to rename the commit. Now you need to show testing/evidence of the changes working.

@stpf99
Copy link
Author

stpf99 commented Jan 5, 2024

in libreelec build overlay and produced img is missing file for systemd sensors for rotation https://github.com/systemd/systemd/blob/main/hwdb.d/60-sensor.hwdb , in this file is adaptation from various sensors in devices to proper screen rotation

@chewitt
Copy link
Member

chewitt commented Jan 5, 2024

I pushed a commit with a minimal version of the file to our systemd package. Please make the same change to your own LE image build and validate that it works?

@stpf99
Copy link
Author

stpf99 commented Jan 5, 2024

sorry files exists and "Bush tablet" is listed in /usr/lib/udev/hwdb.d/60-sensor.hwdb :
cat /etc/udev/hwdb.d/README
Hardware Database Files

The hwdb files are read from the files located in the system hwdb directory
/usr/lib/udev/hwdb.d and the user runtime directory /storage/.config/hwdb.d
All hwdb files are collectively sorted and processed in lexical order, regardless of
the directories in which they live. However, files with identical filenames
replace each other. /usr/lib/udev/hwdb.d/* takes precedence over /storage/.config/hwdb.d/*

@chewitt
Copy link
Member

chewitt commented Jan 5, 2024

However, files with identical filenames replace each other. /usr/lib/udev/hwdb.d/* takes precedence over /storage/.config/hwdb.d/*

The reverse is true, the files in /storage/.config/hwdb.d/* override the embedded location. I'll drop the systemd change.

@stpf99
Copy link
Author

stpf99 commented Jan 5, 2024

LibreELEC:~ # dmesg |grep silead
[ 6.977610] silead_ts i2c-MSSL1680:00: supply vddio not found, using dummy regulator
[ 6.977806] silead_ts i2c-MSSL1680:00: supply avdd not found, using dummy regulator
[ 6.978190] silead_ts i2c-MSSL1680:00: Silead chip ID: 0x80360000
[ 12.585117] silead_ts i2c-MSSL1680:00: Initialization error, status: 0xFFFF0000

LibreELEC:~ # lsmod |grep silead
silead 20480 0

firmware loaded but this init error is in kernel log

@chewitt
Copy link
Member

chewitt commented Jan 5, 2024

I've no idea about the hardware, sorry. I'm blocking the PR until you figure out what's needed (to prevent accidental merge).

@stpf99
Copy link
Author

stpf99 commented Jan 5, 2024

this was succesed by corrupted fw file ,i replaced fw file and touchscreen works , and pointing is accurate in estouchy and estuary in portrait mode, but rotation not work and it is probably because kodi is always in fullscreen, how to resolve this, maybe somewhere is conf for screen orientation..

edit: i will try switch from GBM to Xorg my build

input for touchscreen is initiated:
LibreELEC:~ # dmesg |grep silead
[ 7.454750] silead_ts i2c-MSSL1680:00: supply vddio not found, using dummy regulator
[ 7.454922] silead_ts i2c-MSSL1680:00: supply avdd not found, using dummy regulator
[ 7.455328] silead_ts i2c-MSSL1680:00: Silead chip ID: 0x80360000
[ 9.114531] input: silead_ts as /devices/pci0000:00/808622C1:04/i2c-4/i2c-MSSL1680:00/input/input11

@stpf99
Copy link
Author

stpf99 commented Jan 5, 2024

this two patches also may in X11 / legacy build producing some breaks for kodi screen rotation (https://github.com/LibreELEC/LibreELEC.tv/tree/master/projects/Generic/devices/x11/patches/kodi)

this acpi patch may block if applied obtaining some values for systemd hwdb mechanism from ACPI tables (https://github.com/LibreELEC/LibreELEC.tv/blob/c1cab83d883d18e6bf110367693b85ab91fb4038/projects/Generic/devices/x11/patches/linux/linux-revert-acpi-bus-get-device-5-18.patch )

this fbdev patch if applied may break kodi windowed mode in x11 (https://github.com/LibreELEC/LibreELEC.tv/blob/c1cab83d883d18e6bf110367693b85ab91fb4038/projects/Generic/devices/x11/patches/linux/linux-revert-fbdev--Make-registered-fb---private-to-fbmem-6-1.patch),

i think in gbm images proper static screen orientation /no dynamic rotation could be set by for example
video=DSI-1:800x1280@60,rotate=90(/180/270),panel_orintation=left_side_up (/right_side_up/upside_down/normal)
in arguments in boot cmd line

/can't on my dev test this because i have "i915 0000:00:02.0: [drm] ERROR [CONNECTOR:114:DSI-1] Failed to get the SoC PWM chip"

for fix that some kernel modules needs be included
https://cateee.net/lkddb/web-lkddb/I2C_DESIGNWARE_PCI.html =y/m
https://cateee.net/lkddb/web-lkddb/INTEL_SOC_PMIC.html =m/y
https://cateee.net/lkddb/web-lkddb/PWM_CRC.html =m/y
... related cherry trail PWM = m

also drm_i915 as module must be selected /this resulting also more stable wifi connecting
"
BYT/CHT: pwm vs i915 driver initialization order when i915 is builtin

To reflect that:

This is a generic BYT/CHT issue, not Surface 3 specific

This only is a problem when the i915 driver is builtin"
https://gitlab.freedesktop.org/drm/intel/-/issues/26

in wayland in may img currently autostart kodi is broken somwhere

@stpf99
Copy link
Author

stpf99 commented Jan 7, 2024

for gbm Generic build i have question how to set proper screen rotation, if gbm is trought fb (framebufer) where to setup rotation ?

https://www.x.org/archive/X11R6.8.0/doc/fbdev.4.html

"Option "Rotate" "string"
Enable rotation of the display. The supported values are "CW" (clockwise, 90 degrees), "UD" (upside down, 180 degrees) and "CCW" (counter clockwise, 270 degrees). Implies use of the shadow framebuffer layer. Default: off. "

this my grub cmd boot entry , but in kodi gui i have reversed resolution :800x1280

`LibreELEC2:~ # cat /flash/EFI/BOOT/grub.cfg
set timeout="0"
set default="LibreELEC"

menuentry "LibreELEC" {
search --set -f /KERNEL
linux /KERNEL boot=UUID=6C30-C3D6 disk=UUID=a1c24cd1-cc24-40db-a02c-f6f48f11bc09 gfxmode=1280x800x60 gfxpayload_linux=keep video=DSI-1:1280x800M@60,rotate=90 quiet
}
`
i prepared patch / no tested yet /later i report if gbm img starting in landscape mode

Bush_windows_tablet_drm_panel_orientation_quirks.patch
https://gist.github.com/stpf99/d2e403cd38c68a1eb8daeced32b84723

above patch also in 2nd version for "rightside_up" nothing changes in libreelec test build / on other linux systems kerenels not tested

time to produce wayland test build

@CvH CvH added LE 13.0 and removed LE 12.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants