Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File access only through executor #966

Merged
merged 2 commits into from
Feb 15, 2021
Merged

File access only through executor #966

merged 2 commits into from
Feb 15, 2021

Conversation

uellue
Copy link
Member

@uellue uellue commented Feb 15, 2021

Closes #965

Contributor Checklist:

  • I have added or updated my entry in the creators.json file
  • I have added a changelog entry for my contribution
  • I have added/updated documentation for all user-facing changes
  • I have added/updated test cases

Reviewer Checklist:

  • /azp run libertem.libertem-data passed

@uellue uellue added this to the 0.6 milestone Feb 15, 2021
@uellue uellue added bug Something isn't working file formats and I/O labels Feb 15, 2021
@uellue
Copy link
Member Author

uellue commented Feb 15, 2021

/azp run libertem.libertem-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #966 (ad99165) into master (5059d84) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage   69.44%   69.46%   +0.01%     
==========================================
  Files         269      269              
  Lines       12080    12080              
  Branches     1643     1643              
==========================================
+ Hits         8389     8391       +2     
+ Misses       3385     3384       -1     
+ Partials      306      305       -1     
Impacted Files Coverage Δ
src/libertem/io/dataset/empad.py 84.32% <ø> (ø)
src/libertem/io/dataset/frms6.py 72.36% <ø> (ø)
src/libertem/corrections/corrset.py 95.96% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5059d84...ad99165. Read the comment docs.

Copy link
Member

@sk1p sk1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sk1p
Copy link
Member

sk1p commented Feb 15, 2021

CI failure looks like sphinx-doc/sphinx#8880

@sk1p
Copy link
Member

sk1p commented Feb 15, 2021

Possible workaround: pin sphinx to <3.5

@uellue
Copy link
Member Author

uellue commented Feb 15, 2021

Possible workaround: pin sphinx to <3.5

Ok, I'll try to push here. :-)

@sk1p
Copy link
Member

sk1p commented Feb 15, 2021

One of the windows jobs again hit #963. Good thing is that with Azure Pipelines, we can restart failed jobs, and unlike travis, this also continues running further stages. So if we hit this again while releasing, we can re-trigger without problems (and without having to bump the version...)

@sk1p
Copy link
Member

sk1p commented Feb 15, 2021

/azp run libertem.libertem-data

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@uellue uellue merged commit 9b757e2 into LiberTEM:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working file formats and I/O
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote file opening issues Linux cluster Windows server
2 participants