Pin pytest-asyncio to <0.11 #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around bug in latest version: _____________________ test_start_server __________________________________________________________________ base_url = 'http://127.0.0.1:45153', http_client = <aiohttp.client.ClientSession object at 0x7f2cfedb1e90> @pytest.mark.asyncio async def test_start_server(base_url, http_client): """ start the server and HTTP GET '/', which should return a 200 status code """ url = base_url > async with http_client.get(url) as response: tests/server/test_startup.py:36: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ .tox/py37/lib/python3.7/site-packages/aiohttp/client.py:1012: in __aenter__ self._resp = await self._coro .tox/py37/lib/python3.7/site-packages/aiohttp/client.py:426: in _request with timer: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <aiohttp.helpers.TimerContext object at 0x7f2cfefefd10> def __enter__(self) -> BaseTimerContext: task = current_task(loop=self._loop) if task is None: > raise RuntimeError('Timeout context manager should be used ' 'inside a task') E RuntimeError: Timeout context manager should be used inside a task .tox/py37/lib/python3.7/site-packages/aiohttp/helpers.py:579: RuntimeError
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 58.78% 58.73% -0.06%
==========================================
Files 230 230
Lines 8694 8721 +27
Branches 1133 1138 +5
==========================================
+ Hits 5111 5122 +11
- Misses 3390 3406 +16
Partials 193 193
Continue to review full report at Codecov.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around bug in latest version (pytest-dev/pytest-asyncio#154)
Another workaround is adding
event_loopto all asyncio test cases as a fixture.