Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix new standard linting #800

Closed
wants to merge 1 commit into from
Closed

style: fix new standard linting #800

wants to merge 1 commit into from

Conversation

theoludwig
Copy link

This PR update standard to the next version (v17) coming soon and fixes linting issues (using standard --fix).
This allows having the test-external of standard passing for level/leveldown, before releasing to stable, we ensure that the ecosystem can easily upgrade without issues.

Related: standard/standard#1777

This new version includes:

@@ -48,7 +48,7 @@
"prebuildify-cross": "^4.0.1",
"readfiletree": "^1.0.0",
"rimraf": "^3.0.0",
"standard": "^16.0.3",
"standard": "^17.0.0-2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking the PR as a draft because of this

@vweevers vweevers marked this pull request as draft February 6, 2022 18:50
@theoludwig
Copy link
Author

This PR has no recent activity, and probably won't be merged for a long time and as I don't want/have time to do the job for this PR, I decided to close it.

Feel free to open another PR yourself based on this one if you want this to be implemented.

@theoludwig theoludwig closed this Apr 20, 2022
@theoludwig theoludwig deleted the style/fix-standard-linting branch April 20, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants