Add DerObject.__repr__() #735
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be clear, the entire |
The base case handles sequences and most primitives. Special handling was required for `DerOctetString` and `DerBitString` since they store their value at `.payload` rather than `.value`. Special handling was required for `DerNull` since its current constructor takes no argument at all, not even `None`. This should make "playpenning" around with ASN.1-based formats a lot more convenient.
JamesTheAwesomeDude
force-pushed
the
feature/derobject-repr
branch
from
fde68eb
to
639b60f
Compare
added 2 commits
May 8, 2023 13:07
Considering that the 'else' codepath in the `DerSequence` constructor will encode these objects automatically, this will create valid representations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base case handles sequences and most primitives.
Special handling was given to
DerOctetStringandDerBitStringby way of inspiration from this site — the false-positives still yield technically valid representations, and the true-positives provide tremendous utility when playing around with many real-world ASN.1 formats that nest values within octet- and bit-strings.Special handling was required for
DerNullsince it takes no value, not evenNone, and doesn't currently accept explicit or implicit tag overrides.This should make "playpenning" around with ASN.1-based formats a lot more convenient.
Is this something you'd be interested in merging? Do you have any feedback on it?