Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm(deps-dev): bump node-sass from 4.14.1 to 5.0.0 #187

Closed
wants to merge 1 commit into from
Closed

npm(deps-dev): bump node-sass from 4.14.1 to 5.0.0 #187

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2021 •
edited

Bumps node-sass from 4.14.1 to 5.0.0.

Release notes

Sourced from node-sass's releases.

v5.0.0

Breaking changes

  • Only support LTS and current Node versions (@nschonni)
  • Remove deprecated process.sass API (@xzyfer, #2986)

Features

  • Add support for Node 15
  • New node-gyp version that supports building with Python 3

Community

Fixes

Supported Environments

OS Architecture Node
Windows x86 & x64 10, 12, 14, 15
OSX x64 10, 12, 14, 15
Linux* x64 10, 12, 14, 15
Alpine Linux x64 10, 12, 14, 15
FreeBSD i386 amd64 10, 12, 13

*Linux support refers to major distributions like Ubuntu, and Debian

Commits
  • 0648b5a chore: Add Node 15 support (#2983)
  • e2391c2 Add a deprecation message to the readme (#3011)
  • 6a33e53 chore: Don't upload artifacts on PRs
  • d763506 chore: Only run coverage on main repo
  • d4ebe72 build(deps): update actions/setup-node requirement to v2.1.2
  • 2bebe05 build(deps-dev): bump rimraf from 2.7.1 to 3.0.2
  • f877689 chore: Don't double build DependaBot PRs
  • b48fac4 chore: Add weekly DependaBot updates
  • 91c40a0 Remove deprecated process.sass API
  • 1f6df86 Replace lodash/assign in favor of the native Object.assign
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner February 1, 2021 00:26
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 1, 2021
@dependabot
npm(deps-dev): bump node-sass from 4.14.1 to 5.0.0
dade47e 
Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](sass/node-sass@v4.14.1...v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-sass-5.0.0 branch from 74be7fa to dade47e Compare February 1, 2021 09:21
@owensgit
Copy link
Contributor

owensgit commented Feb 1, 2021 •
edited

Regarding breaking change:

Only support LTS and current Node versions

Currently LTS is 14.15.4 and current release is 15.7.0

In our package.json we specify that 12.13.0 or greater is required:

"engines": {
    "node": ">=12.13.0"
  },

To ensure compatibility at our end, we could bump that to 14.15.4, and then do a smoke test of build.

What does everyone think?

@andy-polhill
Copy link
Contributor

Regarding breaking change:

Only support LTS and current Node versions

Currently LTS is 14.15.4 and current release is `15.7.0

In our package.json we specify that 12.13.0 or greater is required:

"engines": {
    "node": ">=12.13.0"
  },

To ensure compatibility at our end, we could bump that to 14.15.4, and then do a smoke test of build.

What does everyone think?

Makes sense to me, just be sure to update the .nvrmc file and also the pipeline files. (There are probably some optimisations to be had there at some stage in the future.)

@owensgit
Copy link
Contributor

owensgit commented Feb 2, 2021 •
edited

I updated to Node v14.15.4 and ran the build, it completed without errors 👍 . However, when I ran npm run start, the following warnings appeared, which may need some investigation when time allows. An issue on the Node repo suggests using the --trace-warnings flag help pin point it.

info @storybook/angular v5.3.21
info
(node:26721) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26721) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
(node:26721) Warning: Accessing non-existent property 'which' of module exports inside circular dependency

@owensgit
Copy link
Contributor

owensgit commented Feb 2, 2021 •
edited

Closing this PR as I've opened a new draft PR which contains the Node SASS version bump and the changes to our files to set the minimum supported Node version. There is still the outstanding issue of circular dependancy warnings, which is why it's in draft status for now.

@owensgit owensgit closed this Feb 2, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 2, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/node-sass-5.0.0 branch February 2, 2021 08:46
@owensgit owensgit mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owensgit @andy-polhill