-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lg-alert role attibute not being read by VoiceOver #1385
Merged
eduardh-landg
merged 7 commits into
Legal-and-General:master
from
eduardh-landg:alert-role-overwride
May 9, 2024
Merged
Fix lg-alert role attibute not being read by VoiceOver #1385
eduardh-landg
merged 7 commits into
Legal-and-General:master
from
eduardh-landg:alert-role-overwride
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I won't be able to follow up on this discussion up until the 6'th of May but you can seek the wise counsel of Mr. @markblandford. |
markblandford
approved these changes
Apr 22, 2024
taraculpin
previously approved these changes
Apr 25, 2024
paul-request
previously approved these changes
May 7, 2024
Xinchro
reviewed
May 7, 2024
pauleustice
reviewed
May 7, 2024
pauleustice
reviewed
May 7, 2024
eduardh-landg
dismissed stale reviews from paul-request and taraculpin
via
May 9, 2024 10:58
047c83a
eduardh-landg
requested review from
paul-request,
pauleustice and
taraculpin
and removed request for
paul-request
May 9, 2024 10:59
Xinchro
approved these changes
May 9, 2024
taraculpin
approved these changes
May 9, 2024
pauleustice
approved these changes
May 9, 2024
🎉 This PR is included in version 11.13.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the variant setter code is unable to read the role input and automatically sets one. Subsequently, the role is read afterward and adjusted accordingly. Consequently, VoiceOver will behave according to the role set by the variant setter code, despite the role being changed immediately afterward.
Checklist: