Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lg-alert role attibute not being read by VoiceOver #1385

Merged

Conversation

eduardh-landg
Copy link
Contributor

Description

Currently, the variant setter code is unable to read the role input and automatically sets one. Subsequently, the role is read afterward and adjusted accordingly. Consequently, VoiceOver will behave according to the role set by the variant setter code, despite the role being changed immediately afterward.

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have added the documentation
  • I have added any new public feature modules to public-api.ts

@eduardh-landg
Copy link
Contributor Author

I won't be able to follow up on this discussion up until the 6'th of May but you can seek the wise counsel of Mr. @markblandford.

taraculpin
taraculpin previously approved these changes Apr 25, 2024
paul-request
paul-request previously approved these changes May 7, 2024
@eduardh-landg eduardh-landg dismissed stale reviews from paul-request and taraculpin via 047c83a May 9, 2024 10:58
@eduardh-landg eduardh-landg requested review from paul-request, pauleustice and taraculpin and removed request for paul-request May 9, 2024 10:59
@eduardh-landg eduardh-landg removed the request for review from pauleustice May 9, 2024 12:07
@eduardh-landg eduardh-landg merged commit c33b262 into Legal-and-General:master May 9, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented May 9, 2024

🎉 This PR is included in version 11.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants