Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: update to build new variants #1308

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elenagarrone
Copy link
Contributor

@elenagarrone elenagarrone commented Nov 15, 2023

Description

⚠️ DO NOT MERGE ⚠️

This spike confirms that it's possible to create the new variants proposed here:
https://www.figma.com/file/96Kkkoa6u5qfIa92OqKFht/Colour-theme-framework-proposal?type=design&node-id=15-2370&mode=design&t=TmIkszhmN1HCrHky-0

Discussion: #1276

Notes after speaking to Alex C.:

  • All the themes in the design have light and dark foreground options. One of the options will most probably not be accessible but we still want both of them so that if we change main colours (for branding for example) we have the option. The designers will have to tell the devs which variants to use.
  • Do not build subtle option 2. It's a copy of 1 but with slightly different main colours. The designers will decide in future which one to use (the code in the background will be the same)
  • The types of variants will be named bold and subtle.
  • Only the subtle option will have theme-5 (the grey variant).
  • The links might slightly change in the future but for the spike code them as they are in the design.

Demo environment: https://legal-and-general.github.io/canopy/lg-sb-fep-2202-variants-spike/?path=/story/helpers-directives-variant-examples--standard-variant


If using this code in the future (or part of it) please be aware that:

  • it's been coded as a breaking change. We could have a period of time where the old variants are present at the same time as the new ones. In this case we should add a deprecation warning to the old ones.
  • the tests for the variant directive have been disabled.

@github-actions github-actions bot added the deployed The branch is deployed to GitHub Pages label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed The branch is deployed to GitHub Pages do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant