disabling codeclimate linting #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codeclimate doesn't support XO, we would have to maintain a separate eslint config and keep it in sync with XO to get it to work properly. Currently many files just have parse errors becuase the current config doesn't like our ES6-isms like async and spread. Since we already do linting as part of the CI build, I think this is safe to turn off.
|
I agree that we should just turn this off for now, until xojs/xo#122 is resolved at least. |
jeffreywescott
approved these changes
Oct 26, 2016
| enabled: false | ||
| semi: | ||
| enabled: false | ||
| enabled: false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #514
Description
Codeclimate doesn't support XO, we would have to maintain a separate
eslint config and keep it in sync with XO to get it to work properly.
Currently many files just have parse errors because the current config
doesn't like our ES6-isms like async and spread.
Since we already do linting as part of the CI build, I think this is safe to turn off.
Config
nope
Env
nope
Notes
nope