Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency xmldom #106

Merged
merged 1 commit into from Aug 22, 2022
Merged

Update dependency xmldom #106

merged 1 commit into from Aug 22, 2022

Commits on Dec 27, 2021

  1. Update dependency xmldom

    Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
    GHSA-5fg8-2547-mr8q
    
    The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
     xmldom/xmldom#271
    
    - I used node 12 to run `npm install`.
    - I executed `npm run test` on my machine, but it failed because of some missing file:
    ```
    [...]
    > seriate@4.0.0 test:only /run/media/karfau/hdd-data/dev/seriate
    > NODE_ENV=test mocha --exit -r spec/init -R spec 'spec/**/*.spec.js'
    
    Browserslist: caniuse-lite is outdated. Please run:
    npx browserslist@latest --update-db
    
    Why you should do it regularly:
    https://github.com/browserslist/browserslist#browsers-data-updating
    
    Error: Cannot find module './local-config.json'
    Require stack:
    - /run/media/karfau/hdd-data/dev/seriate/spec/integration/one-connection.spec.js
    [...]
    ```
    - I executed `npm run test:ci` onmy machine without failure
    
    I'm one of the xmldom maintainers. Don't hesitate to ask me questions.
    karfau committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    ce982b1 View commit details
    Browse the repository at this point in the history