Add support for curved polylines/polygons using B茅zier curves #9286
Conversation
| noClip: false, | ||
|
|
||
| // @option curved: Boolean = false | ||
| // Enable polyline B茅zier curves. Curved polylines don't support clipping - each line is rendered fully. |
There was a problem hiding this comment.
This needs to reflect that bezier curves are not supported when polylines are drawn on an L.Canvas.
There was a problem hiding this comment.
But that's supported. See changes in src/layer/vector/Canvas.js. SVG drawing commands are transformed into Canvas drawing commands in Canvas.js. I have also added vector-canvas-curved.html to test that.
| const cmds = curvedPathCommands(points, closed); | ||
| for (j = 0; j < cmds.length; j++) { | ||
| const cmd = cmds[j]; | ||
| switch (cmd.type) { |
There was a problem hiding this comment.
I can't see the point of holding "command" objects. The non-bezier code can differentiate between lineTo and moveTo by j===0, so there is no need to do an initial array.push of a M "command" and then push C commands.
There was a problem hiding this comment.
I don't understand what you mean.
Do you want me to replace curvedPathCommands with in-loop calculation of Bezier curve parameters?
It would be more efficient but then the code in the loop would become more complicated.
Also, for polygons (or polylines with closed=true) curvedPathCommands modifies the first C command at the end of the loop to make the joint smooth. It would not be possible if curvedPathCommands was extracted here.
|
Besides, there's plugins like https://github.com/elfalem/Leaflet.curve , so I must ask the question of what does this need to be in the Leaflet core. |
My thinking was that smooth drawing (using curves and not just connecting the dots) of polylines/polygons is an essential feature and if the Leaflet core supports polylines/polygons it should also be able to draw them smoothly.
This particular plugin doesn't do what I want - it draws curves via SVG commands passed explicitly. I want to draw curved polygons, e.g. have an ordered set of dots and draw curves between smoothly (and automatically). It should be possible though to transform the polygons into SVG commands by hand and pass the result to Leaftlet.curve. I leave it up to the maintainers to decide whether this should be a core feature of the lib or it should be implemented externally. |
No description provided.