Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9259 disable text selection #9271

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

9259 disable text selection #9271

wants to merge 5 commits into from

Conversation

ventralnet
Copy link

This fixes #9259 for your review

@IvanSanchez
Copy link
Member

This implementation is incomplete - see the calls to disable/enableTextSelection() in src/dom/Draggable.js and src/map/handler/Map.BoxZoom.js. Those calls should pass a reference to the map container (this._map.getContainer() IIRC).

@ventralnet
Copy link
Author

@IvanSanchez I didn't make those changes because of @mourner response on the original ticket. Supposedly drag operations were performed on the entire document for reasons. I didn't want to effect this with my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L.DomUtil.disableTextSelection should only disable text selection on the map container
2 participants
@ventralnet @IvanSanchez